Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more style properties in the global context #24298

Merged
merged 5 commits into from
Aug 4, 2020

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Jul 30, 2020

Extracted from #24250

This PR adds support for more style properties in the global context.

Testing instructions

  • Install & activate a theme with support for global styles (demo theme).
  • Edit the gutenberg file lib/experimental-theme.json:
{
    "global": {
        "styles": {
            "typography": {
                "fontSize": 12,
                "lineHeight": 2.3
            },
            "color": {
                "text": "red",
                "link": "blue",
                "background": "yellow",
                "gradient": ""gradient": "var(--wp--preset--gradient--blush-bordeaux)"
            }
        }
    }
}
  • Go to the front-end and verify that there is an inlined stylesheet named global-styles-inline-css that contains a style rule with the :root selector. For that style rule, verify that:
    => does have the properties font-size, background-color, background, --wp--style--color--link
    => does not have the properties line-height, color

@oandregal oandregal self-assigned this Jul 30, 2020
@oandregal oandregal added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Jul 30, 2020
lib/global-styles.php Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jul 30, 2020

Size Change: -63 B (0%)

Total Size: 1.16 MB

Filename Size Change
build/block-directory/index.js 7.97 kB +37 B (0%)
build/block-editor/index.js 125 kB +53 B (0%)
build/block-editor/style-rtl.css 10.8 kB -53 B (0%)
build/block-editor/style.css 10.8 kB -52 B (0%)
build/block-library/editor-rtl.css 7.59 kB -5 B (0%)
build/block-library/editor.css 7.59 kB -5 B (0%)
build/block-library/index.js 132 kB -44 B (0%)
build/blocks/index.js 48.3 kB -9 B (0%)
build/components/index.js 200 kB +1 B
build/edit-navigation/index.js 10.9 kB +2 B (0%)
build/edit-post/index.js 304 kB -1 B
build/edit-widgets/index.js 9.38 kB +2 B (0%)
build/editor/index.js 45.3 kB -1 B
build/format-library/index.js 7.72 kB -1 B
build/rich-text/index.js 13.9 kB +13 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.67 kB 0 B
build/api-fetch/index.js 3.44 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/style-rtl.css 953 B 0 B
build/block-directory/style.css 952 B 0 B
build/block-library/style-rtl.css 7.76 kB 0 B
build/block-library/style.css 7.77 kB 0 B
build/block-library/theme-rtl.css 728 B 0 B
build/block-library/theme.css 729 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/components/style-rtl.css 15.7 kB 0 B
build/components/style.css 15.7 kB 0 B
build/compose/index.js 9.68 kB 0 B
build/core-data/index.js 11.8 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.45 kB 0 B
build/date/index.js 5.38 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.23 kB 0 B
build/edit-navigation/style-rtl.css 1.08 kB 0 B
build/edit-navigation/style.css 1.08 kB 0 B
build/edit-post/style-rtl.css 5.61 kB 0 B
build/edit-post/style.css 5.61 kB 0 B
build/edit-site/index.js 17 kB 0 B
build/edit-site/style-rtl.css 3.06 kB 0 B
build/edit-site/style.css 3.06 kB 0 B
build/edit-widgets/style-rtl.css 2.45 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 537 B 0 B
build/editor/editor-styles.css 539 B 0 B
build/editor/style-rtl.css 3.8 kB 0 B
build/editor/style.css 3.79 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.11 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.33 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.41 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/server-side-render/index.js 2.71 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@oandregal oandregal force-pushed the add/support-more-styles-in-global-context branch from 5126866 to 89e4a68 Compare August 2, 2020 19:08
lib/global-styles.php Outdated Show resolved Hide resolved
@oandregal oandregal merged commit 4593301 into master Aug 4, 2020
@oandregal oandregal deleted the add/support-more-styles-in-global-context branch August 4, 2020 15:26
@github-actions github-actions bot added this to the Gutenberg 8.8 milestone Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants